116225 - In Source window Wrap Long Lines doesn't work properly.

Status: NEW

(Toolkit :: View Source, defect)

Description

[Alexander Hessentswey]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.6+) Gecko/20011219
BuildID:    2001121909

In Source window (View source) Wrap Long Lines doesn't work properly.

Reproducible: Always

Comment 1

[Boris Zbarsky [:bzbarsky]]

This bug report is too vague to be useful.  How exactly does it not work?  Does 
wrappig not occur at all?  Does not enough wrapping occur?

Comment 2

[Alexander Hessentswey]

Some lines are wrapped at window edge, and some - at 130% of window width. This
happen with almost all pages.

Comment 3

[Doron Rosenberg (IBM)]

do you have an example site for this?

Comment 4

[Doron Rosenberg (IBM)]

are these 130% lines lines that have no spaces (ie a long url for example)? That
is a known issue

Comment 5

[Alexander Hessentswey]

I think you are right. I don't remember all URLs, but at the most of them there
were long lines without spaces. All URLs I could remember (for example,
http://www.mozilla.org/) are pages with lines that have no spaces.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Let's keep this around to track the issue.  Futuring since the layout work this 
depends on is futured.  Once layout can do wrapping as described in bug 99457, 
this bug is trivial to fix.

Comment 7

[Max Waterman]

Well, I don't know if the bug I am seeing is the same thing or not....

When I view an email with long lines using the
'mail&newsgroups/messageDisplay/wrapTextToFitWindowWidth' option checked, it
displays it fine. If I then reply to the email, it does not wrap the lines, even
though the 'Preferences/MessageComposition/WrapPlainTextMessagesAt' is set to 72
characters.

Previous behaviour was to wrap the text, but it didn't add the 'quote' to the
wrapped lines; so I would get a message like this :

Max Waterman wrote :
> hello this is a very long line hello this is a very long line hello this is a
very long line hello this is a very long line 
> hello this is another very long line hello this is a very long line hello this
is a very long line hello this is a very long line 

and I would have to add the '>' to the beginning of the lines that were wrapped.

Obviously, I am quoting 'inline'.

Comment 8

[André Dahlqvist]

Did bug 124753 fix this?

Comment 9

[Boris Zbarsky [:bzbarsky]]

Not at all.  Please read this bug again.

Comment 10

[Boris Zbarsky [:bzbarsky]]

*** Bug 153536 has been marked as a duplicate of this bug. ***

Comment 11

[Gavin Treadgold]

This looks like a better place than registering a new bug :)

I have an issue with wrapping long line of text, such as a meta keywords field
that may have a long list of comma delineated words with no space. The behaviour
I would expected is that the view source window breaks after a comma, and the
next word starts on the new line, however this in not the case. I just get a
super long line of content="asd,asd,asd,asd". This may not exactly be an easy
fix, as how do you break a URL such as those sites that have 123,,42343.html.
Then again, I think breaking apart URL's with a comma in them would be a small
price to pay to have long strings broken at ,;. No doubt I have missed some
glaring issue as to why this can't be done :)

Cheers Gav

Comment 12

[Boris Zbarsky [:bzbarsky]]

Yeah, that's this bug... and it depends on bug 99457.

One hint for why breaking at "," is generally no good -- "4,53" in Europe is 4
and 53/100.  You don't want to line-break that.

Comment 13

[Boris Zbarsky [:bzbarsky]]

No plans to work on this any time in the foreseeable future, so to default owner.

Comment 14

[Mark R. Bannister]

*** Bug 228927 has been marked as a duplicate of this bug. ***

Comment 15

[Harrie]

(In reply to comment #12)
> One hint for why breaking at "," is generally no good -- "4,53" in Europe is 4
> and 53/100.  You don't want to line-break that.

I agree when you're talking about "normal" mode (e.g. when it's rendered), but
this bug is about View Source, what's the problem with a line-break there?

(Added myself to CC list)

Comment 16

[Hermann Schwab]

(In reply to comment #12)
> Yeah, that's this bug... and it depends on bug 99457.
> 
> One hint for why breaking at "," is generally no good -- "4,53" in Europe is 4
> and 53/100.  You don't want to line-break that.

What is the difference to 4.53? Don't you line-break at decimal point? How do you know it's a decimal point if you don't test the next character being a digit?
The languages I know a "," is either preceded by a letter and followed by a space, or preceded by a digit and followed by a digit. In US numbers sometimes  a preceding zero isn't written.
1$, 1.23$, .23$, 1 Euro, 1,23 Euro, 0,23 Euro.

Comment 17

[plop]

may be dup of bug 267832 ?

linked with bug 242896 ?

Comment 18

[plop]

"4,53" is clearly an european number ... and has only one coma. "123,,42343.html" has several: you can count commas in the word. Then, a problem may appear only in the case of CSV files pasted in the body of email, and having only two columns. That's a very rare case :)

Comment 19

[Philip Chee]

SeaMonkey trunk is now using toolkit viewsource.