Closed Bug 1162449 Opened 9 years ago Closed 9 years ago

[Stingray] smart-bubbles web component should also support sinking animation

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dwi2, Assigned: dwi2)

References

Details

Attachments

(1 file)

pull request
56 bytes, text/x-github-pull-request
johnhu
: review+
Details | Review 
We only have bubble-up animation in smart-bubbles. We also need 'sinking animation' in card filter case.
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Attached file pull request — 
Hi John,

Please help to review the patch. Thanks
Attachment #8603290 - Flags: review?(im)
Comment on attachment 8603290 [details] [review]
pull request

looks good to me.
Attachment #8603290 - Flags: review?(im) → review+
Thanks.

Landed on smart-bubbles/master
https://github.com/smart-components/smart-bubbles/commit/afc1ee8602626e712580076839648bc83074bf16
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 1163535
Blocks: 1163538
Blocks: 1163977
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: