Closed
Bug 1162524
Opened 9 years ago
Closed 9 years ago
Fix connect/accept in |UnixSocketWatcher|
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
2.2 S12 (15may)
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(2 files)
1.31 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
10.37 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
The |Connect| method in |UnixSocketWatcher| incorrectly returns an error if it takes longer on a non-blocking socket. That is not an error. Accepting connection requests should be moved out of |UnixSocketWatcher|. This will allow for more flexibility.
Assignee | ||
Comment 1•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a0d4881fcfd
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8602760 -
Flags: review?(kyle)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8602761 -
Flags: review?(kyle)
Updated•9 years ago
|
Attachment #8602760 -
Flags: review?(kyle) → review+
Updated•9 years ago
|
Attachment #8602761 -
Flags: review?(kyle) → review+
https://hg.mozilla.org/integration/b2g-inbound/rev/7f7d734605b1 https://hg.mozilla.org/integration/b2g-inbound/rev/a099b6c77366
Assignee | ||
Comment 5•9 years ago
|
||
Thanks Kyle. https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=a099b6c77366
https://hg.mozilla.org/mozilla-central/rev/7f7d734605b1 https://hg.mozilla.org/mozilla-central/rev/a099b6c77366
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S12 (15may)
Blocks: 1163089
You need to log in
before you can comment on or make changes to this bug.
Description
•