Closed
Bug 1162644
Opened 9 years ago
Closed 9 years ago
Call PORT_SetError after calling SSL3_SendAlert
Categories
(NSS :: Libraries, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
3.19.1
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
|
9.72 KB,
patch
|
mt
:
review+
wtc
:
checked-in+
|
Details | Diff | Splinter Review |
The proposed patch changes ssl3ext.c to call PORT_SetError after the SSL3_SendAlert calls. This is a pattern we follow when convenient. The reason is that any function we call after PORT_SetError may potentially change the error code, even if the function succeeds. NSS functions, like most other library functions, only guarantee the error code is correctly set if they fail. (The SSL3_SendAlert calls I modified seem to be newly added in bug 753136.)
Attachment #8602861 -
Flags: review?(martin.thomson)
|
||
Updated•9 years ago
|
Attachment #8602861 -
Flags: review?(martin.thomson) → review+
|
Assignee | |
Comment 1•9 years ago
|
||
Comment on attachment 8602861 [details] [diff] [review] Proposed patch https://hg.mozilla.org/projects/nss/rev/807f2b757826
Attachment #8602861 -
Flags: checked-in+
|
|
Assignee | |
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•