Closed Bug 1162694 Opened 9 years ago Closed 9 years ago

Remove XULAPP_DEFINES from DOM Inspector

Categories

(Other Applications :: DOM Inspector, defect)

defect
Not set
normal

Tracking

(firefox40 fixed, seamonkey2.37 fixed)

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed
seamonkey2.37 --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

Attachments

(1 file)

Bug 1155283 is planning to remove XULAPP_DEFINES, so need to fix DOM Inspector so it does not use it.
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #8603308 - Flags: review?(philip.chee)
Comment on attachment 8603308 [details] [diff] [review]
Remove use of XULAPP_DEFINES from DOM Inspector [Checked in: Comment 3]

> +DEFINES = -DDOMi_VERSION=$(DOMi_VERSION)
DEFINES += -DDOMi_VERSION=$(DOMi_VERSION)

r=me (assuming that it works)
Attachment #8603308 - Flags: review?(philip.chee) → review+
Comment on attachment 8603308 [details] [diff] [review]
Remove use of XULAPP_DEFINES from DOM Inspector [Checked in: Comment 3]

With suggested tweak
http://hg.mozilla.org/dom-inspector/rev/a60fa07fdae5
Attachment #8603308 - Attachment description: Remove use of XULAPP_DEFINES from DOM Inspector → Remove use of XULAPP_DEFINES from DOM Inspector [Checked in: Comment 3]
Target Milestone: --- → mozilla40
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: