1163501 - [Stingray] Dashboard app folder and template

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[yifan [:yifan][:yliao]]

Initialize Dashboard app folder and template.

Comment 1

[yifan [:yifan][:yliao]]

Attachment: 1163501.patch

Scaffolding following the style in smart-home. Would like to get your feedback on what needs to be changed and what's missing. Thanks!

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8604547 [details] [diff] [review]
1163501.patch

Review of attachment 8604547 [details] [diff] [review]:
-----------------------------------------------------------------

::: tv_apps/dashboard/js/dashboard.js
@@ +5,5 @@
> +  // demo only
> +  var main = document.getElementById('main-section');
> +  main.focus();
> +  document.body.addEventListener('keydown', function (e) {
> +    states[current].onkeydown(e);

Have you tried shared/js/smart-screen/key_navigation_adapter.js?

we may need to listen to onbeforekeydown instead since keydown event doesn't propagate to parent browser frame.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8604547 [details] [diff] [review]
1163501.patch

Review of attachment 8604547 [details] [diff] [review]:
-----------------------------------------------------------------

::: tv_apps/dashboard/js/dashboard.js
@@ +13,5 @@
> +  var states = {
> +    center: {
> +      onkeydown: function (e) {
> +        switch (e.keyCode) {
> +          case 38:

Please use KeyEvent.DOM_VK_LEFT, KeyEvent.DOM_VK_RIGHT, KeyEvent.DOM_VK_UP, KeyEvent.DOM_VK_DOWN instead of the number.

@@ +14,5 @@
> +    center: {
> +      onkeydown: function (e) {
> +        switch (e.keyCode) {
> +          case 38:
> +            current = 'top';

Do we really need to update the variable current? We may check the class list of main section to know the current panel.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Please add unit tests and integration tests. Thanks.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] begeeben:1163501_dashboard_app_folder > mozilla-b2g:master

Comment 6

[yifan [:yifan][:yliao]]

Comment on attachment 8605669 [details] [review]
[gaia] begeeben:1163501_dashboard_app_folder > mozilla-b2g:master

* Use KeyNavigationAdapter for arrow key events.
* Add unit and integration tests.

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8605669 [details] [review]
[gaia] begeeben:1163501_dashboard_app_folder > mozilla-b2g:master

Looks good to me. Please remove the APP_URL and app loading since they are useless.

Comment 8

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8605669 [details] [review]
[gaia] begeeben:1163501_dashboard_app_folder > mozilla-b2g:master

sorry. wrong test result.

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Looks good to me, but please confirm the key behavior with UX. (opposite direction key or same direction key to shrink widget)

Comment 10

[yifan [:yifan][:yliao]]

Comment on attachment 8605669 [details] [review]
[gaia] begeeben:1163501_dashboard_app_folder > mozilla-b2g:master

Thanks! Confirmed with UX and fixed integration test. Please see if there's anything needed.

Comment 11

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8605669 [details] [review]
[gaia] begeeben:1163501_dashboard_app_folder > mozilla-b2g:master

looks good to me.

Comment 12

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8605669 [details] [review]
[gaia] begeeben:1163501_dashboard_app_folder > mozilla-b2g:master

Looks good to me. thanks!

Comment 13

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/30060

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

Comment 14

[Kevin Grandon :kgrandon]

Trying again due to tree closures. Sorry about the spam here.

Comment 15

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/a4aea5ac82788521a6f13304c0ae7d52540b2238