1163993 - [gtk3] crash @ nsNativeThemeGTK::DrawWidgetBackground()

Status: RESOLVED DUPLICATE of bug 1127752

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Reproduction steps:

go to duckduckgo.com, enter some text to search box

in nsNativeThemeGTK::DrawWidgetBackground()
900	  cairo_t *cairo_ctx =
901	    (cairo_t*)aDrawTarget.GetNativeSurface(NativeSurfaceType::CAIRO_CONTEXT); 

cairo_ctx is null.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

looks like the aDrawTarget is mozilla::gfx::DrawTargetDual type which does not have cairo context.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: workaround

I'm not sure this is the correct solution but it prevents the browser from crashes at least.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8605210 [details] [diff] [review]
workaround

Karl, what do you think? Do we need to support the dual target?

Comment 4

[Karl Tomlinson (:karlt)]

Comment on attachment 8605210 [details] [diff] [review]
workaround

Do the changes from bug 1127752 help here?

If not, its probably best to ask Lee what the best solution here would be.
(He will be more likely to know about DrawTargetDual than I.)

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Bug 1127752 seems to fixed that, Thanks.