Closed
Bug 1164326
Opened 9 years ago
Closed 9 years ago
Add integration tests for app modal dialog
Categories
(Firefox OS Graveyard :: Gaia::TV::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chens, Assigned: chens)
References
Details
Attachments
(1 file)
Since the app modal dialog is operated by keyboard, we should create a integration tests to operate it with keyboard.
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8605045 [details] [review] [gaia] shamenchens:Bug1164326-appmodaldialog-integration-test > mozilla-b2g:master John, would you review this? thanks.
Attachment #8605045 -
Flags: review?(im)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Try to enable on treeherder[1], test running on gij15[2] and pass. [1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=1f9235637dccd72fb63669f04fd784601b38a5f3 [2]: https://s3-us-west-2.amazonaws.com/taskcluster-public-artifacts/Mo39sGafQZ-0G4t79r2H3g/0/public/logs/live_backing.log
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8605045 [details] [review] [gaia] shamenchens:Bug1164326-appmodaldialog-integration-test > mozilla-b2g:master Good. Thanks for testing it at tree herder.
Attachment #8605045 -
Flags: review?(im) → review+
|
||
Comment 5•9 years ago
|
||
The tests also work well in MacOS(in my computer).
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Comment 6•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/827289ee7f74292a17bfa73a89e43d5a2bcc4e86
|
|
||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•