1164844 - Update mozilla-download version used by marionette-js-runner to >=1.0

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Gareth Aye [:gaye] (back from PTO)]

marionette-js-runner builds are currently failing since they are using an outdated version of mozilla-download

Comment 1

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/marionette-js-runner/pull/75

r=self

Comment 2

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/marionette-js-runner/commit/b49450da40738dbb5fb04393691e401fce91f4b2 landed on master

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

If doing r=self for things, it's usually best/standard to indicate what makes that usually not-okay thing okay.  This is usually some agreed-upon tag by the owner/peers for the module in question with an "a=" or "rs=" (for rubber stamp).  For example, in Thunderbird we had "rs=simple-orange-fix" and "rs=orange-debugging" documented at https://developer.mozilla.org/en-US/docs/Mailnews_and_Mail_code_review_requirements.

Note that I'm not taking issue with the contents of this change, just trying to mention this especially as we move towards having more things live in directly in gaia it's good to adopt such things so there's less confusion for all.  Especially newcomers who might look at logs and intuit incorrect things from "r=self" versus "rs=version-bump" or "rs=tested-version-bump".