Closed
Bug 1165011
Opened 9 years ago
Closed 9 years ago
Remove Symbol_isRegExp from CommonPropertyNames.h.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla43
People
(Reporter: arai, Assigned: arai)
Details
Attachments
(1 file)
|
1.40 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
https://dxr.mozilla.org/mozilla-central/source/js/src/vm/CommonPropertyNames.h#255 > macro(Symbol_isRegExp, Symbol_isRegExp, "Symbol.isRegExp") \ It's already removed from the spec, and now we have Symbol.match instead.
|
Assignee | |
Comment 1•9 years ago
|
||
Just removed unused name.
Assignee: nobody → arai.unmht
Attachment #8613252 -
Flags: review?(terrence)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8613252 [details] [diff] [review] Remove Symbol_isRegExp. This is more Jason's area.
Attachment #8613252 -
Flags: review?(terrence) → review?(jorendorff)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8613252 [details] [diff] [review] Remove Symbol_isRegExp. Review of attachment 8613252 [details] [diff] [review]: ----------------------------------------------------------------- Arai, I'm really sorry for the delay here. By all means.
Attachment #8613252 -
Flags: review?(jorendorff) → review+
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/67506708c201
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•