1165048 - Music playback is getting stopped and is not resumed when modem is restarted

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Diego Wilson [:diego]]

This is happening on a Lollipop prototype being used by CAF. When the modem is restarted on this device the audio media framework gets hosed and no more audio clips can be played until the phone is restarted.

The reason is that in this device the gonk system process attempts to update audio settings. However, we currently only allow the radio and bluetooth processes to update audio settings [1]. This is easily fixed by granting audio settings permission to the system process too (AID_SYSTEM).

[1] https://mxr.mozilla.org/mozilla-central/source/widget/gonk/GonkPermission.cpp#123

Comment 1

[Dylan Oliver [:doliver]]

Hsin-Yi, are you ok with Diego's suggestion to grant audio settings permission to System?

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Dylan Oliver [:doliver] from comment #1)
> Hsin-Yi, are you ok with Diego's suggestion to grant audio settings
> permission to System?

It looks fine to me, but Michael seems the right reviewer.

Comment 3

[Ken Chang[:kenkai]]

Steven, what do you think for this?

Comment 4

[StevenLee[:slee]]

(In reply to Ken Chang[:ken] from comment #3)
> Steven, what do you think for this?

I think it's OK, but we need mwu's approval.

Comment 5

[Diego Wilson [:diego]]

Attachment: Add permission to modify audio settings to system process

Comment 6

[Diego Wilson [:diego]]

Try results look good to me https://treeherder.mozilla.org/#/jobs?repo=try&revision=698b309593de

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/c92eb84dfd39

Comment 8

[Diego Wilson [:diego]]

Comment on attachment 8607716 [details] [diff] [review]
Add permission to modify audio settings to system process

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
Bug 976839

User impact if declined:
Bluetooth will not recover gracefully after a bluetooth subsystem crash.

Testing completed:
Force crashed the bluetooth subsystem on Flame Kitkat and a Lollipop prototype device. My bluetooth headset reconnected correctly.

Risk to taking this patch (and alternatives if risky): 
There are no obvious risks I can identify.

String or UUID changes made by this patch:
None

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c92eb84dfd39

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4df8f8b1beb0