1165274 - Code style hinting warns despite disabled by jshint code comment

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Thomas Jensen]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150513195316

Steps to reproduce:

Run this code from Petka Antonov's Bluebird module:

https://github.com/petkaantonov/bluebird/blob/7caba852c072f2ea3622b40c0b7a6eeb3fae97d3/src/util.js#L177-L186


Actual results:

The console has the warning "SyntaxError: unreachable code after return statement".


Expected results:

Nothing

Comment 1

[Jeff Walden [:Waldo]]

SpiderMonkey's warnings are separate and distinct from jshint's warnings, and we don't pay them any attention.  I don't think we're going to adopt a policy of searching out the warnings they have, that superset the warnings we have (whatever warning this jshint thing is, I'm betting it's not exactly what we have here), and going to extra effort to detect when the developer has opted out of that narrow set of jshint warnings.