Closed Bug 1165291 Opened 9 years ago Closed 9 years ago

Pocket Social Api not removed if it was reinstalled in a downgrade

Categories

(Firefox :: Pocket, defect, P3)

Product:
Firefox
Component:
Pocket
Version:
38 Branch
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: VarCat, Unassigned)

Details

Environment:

FF 38.0.5
Build Id: 20150514163436

STR:

1. Using and older version of Firefox( FF 37) install Pocket Social Api from https://getpocket.com/firefox/ page.
2. Close the older version of Firefox.
3. Start FF 38.0.5 using the same profile as the one from step1.
4. Go to about:addons Services.
Issue1 :
The Pocket Social Api was incorectly removed instead of being disabled.
5. Close FF 38.0.5.
6. Start the older version of Firefox using the same profile as the one from Step 1 and reinstall the Pocket Social Api.
7. Close the older FF version.
9. Start FF 38.0.5 using the same profile as the one from step1.
10. Go to about:addons Services.
Issue 2:
This time the Pocket Social Api is enabled instead of disabled.
OS: Unspecified → All
Hardware: Unspecified → All
Assignee: benjamin → nobody
Component: Plugin Click-To-Activate Whitelist → Pocket
(In reply to Catalin Varga [QA][:VarCat] from comment #0)

> Issue1 :
> The Pocket Social Api was incorectly removed instead of being disabled.

This is actually expected. We remove the SocialAPI service entirely, since the 38.0.5 integration is strictly better.

(We do store that fact in a pref, should we later choose to undo it.)

> 5. Close FF 38.0.5.
> 6. Start the older version of Firefox using the same profile as the one from
> Step 1 and reinstall the Pocket Social Api.
> 7. Close the older FF version.
> 9. Start FF 38.0.5 using the same profile as the one from step1.
> 10. Go to about:addons Services.
> Issue 2:
> This time the Pocket Social Api is enabled instead of disabled.

Hmm, but that seems unexpected.

Drew, is this expected from how bug 1155521 was implemented?
Flags: needinfo?(adw)
Summary: Pocket Social Api is not correctly disabled → Pocket Social Api not removed if it was reinstalled in a downgrade
Calling this a P3 because it seems unlikely that many users will do this, and if they do the effect should just be that they get 2 functional buttons, either one of which can be simply removed.
Priority: -- → P3
Yeah, that code to install the button/remove the social api implementation is only run once.
Flags: needinfo?(adw)
I should also add our plan is to take down the social api version after June 2nd, so users won't be able to reinstall it.
Closing based on comment #4.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.