1165385 - Remove the non-full format option from MOZ_GCTIMER

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: cleanup_remove_fullFormat-v0.diff

It adds non-zero complexity and it isn't terribly useful. At least, it doesn't add anything that a bit of grep and sed can't also add, and with tremendously more flexibility. At the very least, the totally different output mode should not alias the same environment variable -- for now I'm just going to remove it.

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8606375 [details] [diff] [review]
cleanup_remove_fullFormat-v0.diff

Review of attachment 8606375 [details] [diff] [review]:
-----------------------------------------------------------------

Good call. The terse format didn't really bother me, but the weird dependence on the output location for which type of format you got was nasty. I had on my todo list to make them orthogonal, but you're right, there's no need for the terse format in the first place.

Comment 2

[Terrence Cole [:terrence]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc668b08e3e8

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/de37ce76d3f5

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/de37ce76d3f5