1165463 - Inline push/pop/shift on unboxed arrays in Ion

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

This is pretty straightforward.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: patch

Remove an extraneous modification to the octane source.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8606651 [details] [diff] [review]
patch

Review of attachment 8606651 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/IonBuilder.cpp
@@ +5207,5 @@
>      JSFunction* target = &targetArg->as<JSFunction>();
>      if (target->isNative()) {
>          InliningStatus status = inlineNativeCall(callInfo, target);
> +        if (status == InliningStatus_NotInlined)
> +            status = inlineNativeCall(callInfo, target);

What's the point of this?

Comment 3

[Brian Hackett [Laid off!]]

(In reply to Jan de Mooij [:jandem] from comment #2)
> Comment on attachment 8606651 [details] [diff] [review]
> patch
> 
> Review of attachment 8606651 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/jit/IonBuilder.cpp
> @@ +5207,5 @@
> >      JSFunction* target = &targetArg->as<JSFunction>();
> >      if (target->isNative()) {
> >          InliningStatus status = inlineNativeCall(callInfo, target);
> > +        if (status == InliningStatus_NotInlined)
> > +            status = inlineNativeCall(callInfo, target);
> 
> What's the point of this?

Oops, this was in place for debugging.

Comment 4

[Jan de Mooij [:jandem]]

Comment on attachment 8606651 [details] [diff] [review]
patch

Review of attachment 8606651 [details] [diff] [review]:
-----------------------------------------------------------------

OK, r=me with the debugging code removed.

Comment 5

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/57dce88fc620

Comment 6

[Guilherme Lima]

https://hg.mozilla.org/mozilla-central/rev/57dce88fc620