Closed
Bug 1165735
Opened 9 years ago
Closed 9 years ago
Make ThreadSharedFloatArrayBufferList::mContents infallible
Categories
(Core :: Web Audio, defect)
Core
Web Audio
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: poiru, Assigned: poiru)
References
Details
Attachments
(1 file)
|
1.01 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
ThreadSharedFloatArrayBufferList::mContents is currently a AutoFallibleTArray. However, in the ThreadSharedFloatArrayBufferList constructor, `mContents.SetLength` is used without checking its return value. We should either fix that (because it will cause a warning after bug 968520 lands) or make mContents a nsAutoTArray. ThreadSharedFloatArrayBufferList objects seem to created using infallible new[0], so making mContents infallible should be safe. [0]: http://mxr.mozilla.org/mozilla-central/search?string=new+ThreadSharedFloatArrayBufferList
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8606762 -
Flags: review?(roc)
Attachment #8606762 -
Flags: review?(roc) → review+
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/42bb6fb19a10
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•