Closed Bug 1165835 Opened 9 years ago Closed 9 years ago

[bluetooth2] Fix build break resulting from Bug 1164292

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox41 fixed)

RESOLVED FIXED
2.2 S13 (29may)
Tracking Status
firefox41 --- fixed

People

(Reporter: yrliou, Assigned: yrliou)

References

Details

(Whiteboard: [webbt-api])

Attachments

(1 file, 1 obsolete file)

Bug 1164292 revise the function signature of nsIPrincipal::GetOrigin.
We need to revise our function call at https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/bluetooth2/BluetoothAdapter.cpp#986 to fix the build break.
Hi Ben,

Please help to review my patch.

Thanks,
Jocelyn
Attachment #8606934 - Flags: review?(btian)
Comment on attachment 8606934 [details] [diff] [review]
Bug 1165835: Fix bluetooth2 build break resulting from Bug 1164292.

Review of attachment 8606934 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8606934 - Flags: review?(btian) → review+
* no try server result since bluetooth2 won't be built.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e115d9fb3e04
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S13 (29may)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: