Closed
Bug 1165925
Opened 9 years ago
Closed 9 years ago
web-server.js should serve index.html at the site root
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
Details
Attachments
(1 file)
Currently index.html is served from localhost:8000/app/index.html This would be better as localhost:8000/index.html, ie document root of webapp/app/ not webapp/
Assignee | ||
Updated•9 years ago
|
Summary: web-server.js's document root should serve index.html at the site root → web-server.js should serve index.html at the site root
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8607074 -
Flags: review?(wlachance)
Comment 2•9 years ago
|
||
Fwiw I just tested this branch locally and everything seems fine, it's serving production correctly, and the instructions look good.
Comment 3•9 years ago
|
||
Comment on attachment 8607074 [details] [review] web-server.js should serve index.html at the site root This does make more sense, thanks.
Attachment #8607074 -
Flags: review?(wlachance) → review+
Comment 4•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/e26918ce40f203403542987a3fa4e0722191156b Bug 1165925 - web-server.js should serve index.html at the site root
Assignee | ||
Comment 5•9 years ago
|
||
Thank you for the review :-)
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 6•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/90e3aa0deafef9d85db55afd12b0a99b66d951d4 Bug 1165925 - web-server.js should serve index.html at the site root
Updated•2 years ago
|
Component: Treeherder: Docs & Development → TreeHerder
You need to log in
before you can comment on or make changes to this bug.
Description
•