Closed Bug 1165959 Opened 9 years ago Closed 9 years ago

The "Autotheme >" link on the Detail panel is broken

Categories

(Firefox OS Graveyard :: Gaia::Theme Editor, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Theme Editor
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: etienne, Assigned: hub)

References

Details

Attachments

(1 file)

Link to Github pull-request: https://github.com/fxos/studio/pull/20
38 bytes, text/x-github-pull-request
etienne
: review+
Details | Review 
It does nothing an eventually errors.

According to the spec it shouldn't be here anyway so we should remove it and make sure we're not leaving dead code.
Blocks: spark-theme-editor
Priority: -- → P1
Is it possible that it's not in the spec because the specifier did not see it was here originally ?

I still think it's a useful feature to convert an existing theme -- but maybe that's just me :)
I still want to keep in on the new theme dialog so that you can make autotheme without going though the webactivity.

But doing it on an existing theme will erase the prior colors so I think it's more confusing than helping.
Yeah makes sense !
Summary: The "Autothme >" link on the Detail panel is broken → The "Autotheme >" link on the Detail panel is broken
Remove the HTML. The JS code is actually used elsewhere.
Assignee: nobody → hub
Status: NEW → ASSIGNED
Attachment #8616334 - Flags: review?(etienne)
https://github.com/fxos/studio/commit/2a63e288b4533abd79648b8fc6393fbf9c083ff9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attachment #8616334 - Flags: review?(etienne) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: