1165978 - Dev-Toolbar cannot be reopened

Status: RESOLVED INCOMPLETE

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P2)

Description

[Elbart]

Open the browser
Hit Shift-F2 for the toolbar.
Type in "screenshot --", the tooltip-balloon should appear.
Close the toolbar using its X-button or Shift-F2.
Hit Shift-F2 again.

ER:
Toolbar opens.

AR:
Toolbar cannot be opened again.
In the "Developer"-subpanel in the hamburglar-menu, "Developer Toolbar" is checked, as if it was opened.
Clicking on that menuitem throws this error:

19:38:39.389 TypeError: arg.assignment is undefined
Stack trace:
Requisition.prototype.getAssignmentAt@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/cli.js:821:1
Requisition.prototype.getStateData@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/cli.js:1221:17
Completer.prototype._getCompleterTemplateData@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/mozui/completer.js:136:10
Completer.prototype.update@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/mozui/completer.js:114:3
Completer@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/mozui/completer.js:76:3
DeveloperToolbar.prototype.show/this._showPromise</</</<@resource:///modules/devtools/DeveloperToolbar.jsm:430:28
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:867:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:746:7
this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:688:37
Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:688:5
this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:709:7
this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:671:7
Front<.onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1217:7
DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:953:7
LocalDebuggerTransport.prototype.send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js:561:11
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
1 Promise-backend.js:870

At this stage, when you close and reopen the browser, it is starting with the toolbar being activated.

This is happening with e10s on and off.

Comment 1

[Alice0775 White]

Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=261ac0a51324&tochange=4e05844b3986

Regressed by:
6e5607b09d8f	Joe Walker — Bug 992309 - Don't leak gcli promise to other tests; r=mratcliffe

Comment 2

[Firefox Bug Husbandry Bot]

Per bug 1491875, this component has been closed, and the affected code is being removed from Firefox. Closing this bug as incomplete.