1166037 - ARM64: Import Baseline

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Sean Stangl [:sstangl]]

Attachment: 0001-Modify-common-Baseline-code-for-ARM64.patch

This bug is for the small Baseline changes for ARM64, and for the ARM64-specific Baseline code. I should have addressed all the review points raised from the reviews in Bug 1088326. Making separate bugs for each component for the sake of organization.

The intention is to land these patches independent of the other ARM64 patches ASAP, then hook them all together with a build system patch at the end.

Patch 1/2: Modifications to shared code, which mostly just involves not saying "BaselineStackReg" anymore.

Comment 1

[Sean Stangl [:sstangl]]

Attachment: 0002-Import-ARM64-specific-Baseline-code.patch

Part 2: Import ARM64-specific Baseline code.

Comment 2

[Kannan Vijayan [:djvj]]

Comment on attachment 8607183 [details] [diff] [review]
0001-Modify-common-Baseline-code-for-ARM64.patch

Review of attachment 8607183 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/BaselineBailouts.cpp
@@ +1556,5 @@
>  
>      // Do stack check.
>      bool overRecursed = false;
> +    BaselineBailoutInfo *info = builder.info();
> +    uint8_t *newsp = info->incomingStack - (info->copyStackTop - info->copyStackBottom);

Nit: use new pointer-syntax conventions.

"T* varname" not "T *varname"

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/31ba39bfadb0

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f88e60f3954c

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2372db222b85

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2372db222b85