Closed
Bug 1166078
Opened 9 years ago
Closed 9 years ago
Clean up and add expected result strings to test_hmac.js
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: Cykesiopka, Assigned: Cykesiopka)
Details
Attachments
(1 file, 1 obsolete file)
The main goal is to add expected result strings, but the file currently has several issues that can be cleaned up as well: - Trailing whitespace - Typos - Uses var instead of let ... etc
Assignee | ||
Comment 1•9 years ago
|
||
/r/8977 - Bug 1166078 - Clean up and add expected result strings to test_hmac.js. Pull down this commit: hg pull -r d3f90cad944d228b66e2c545e835f170a622bde6 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8607246 -
Flags: review?(dkeeler)
https://reviewboard.mozilla.org/r/8977/#review7627 Looks great!
Attachment #8607246 -
Flags: review?(dkeeler) → review+
Comment on attachment 8607246 [details] MozReview Request: bz://1166078/Cykesiopka https://reviewboard.mozilla.org/r/8975/#review7629 Ship It!
Assignee | ||
Comment 4•9 years ago
|
||
Thanks for the review. https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e865c20b124
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/360e42b79297
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8607246 -
Attachment is obsolete: true
Attachment #8620318 -
Flags: review+
Assignee | ||
Comment 8•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•