1166274 - [B2G][Wifi] WifiManager.setStaticIpMode() never triggers success or error event

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Edgar Chen [:edgar]]

+++ This bug was initially created as a clone of Bug #1123328 +++

Found this bug when trying to write a test for static ip. Please see bug #1123328 comment #4.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Part 1: Fix, v1

Comment 2

[Edgar Chen [:edgar]]

Attachment: Part 2: Test, v1

Comment 3

[Edgar Chen [:edgar]]

Comment on attachment 8607527 [details] [diff] [review]
Part 1: Fix, v1

Review of attachment 8607527 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Vincent, would you mind reviewing this? Thank you.

Comment 4

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8607527 [details] [diff] [review]
Part 1: Fix, v1

Review of attachment 8607527 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you.

Comment 5

[Henry Chang [:hchang]]

Comment on attachment 8607628 [details] [diff] [review]
Part 2: Test, v1

Review of attachment 8607628 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks Edgar!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/86ab6cc5a3ae
https://hg.mozilla.org/integration/b2g-inbound/rev/e532ebecafc6

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/86ab6cc5a3ae
https://hg.mozilla.org/mozilla-central/rev/e532ebecafc6