Closed
Bug 1166380
Opened 9 years ago
Closed 9 years ago
Add an (empty) "taskcluster" build pool
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Release Engineering
Applications: MozharnessCore
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: dustin)
References
Details
Attachments
(3 files, 2 obsolete files)
721 bytes,
patch
|
mshal
:
review+
dustin
:
checked-in+
|
Details | Diff | Splinter Review |
39 bytes,
text/x-review-board-request
|
mshal
:
review+
|
Details |
39 bytes,
text/x-review-board-request
|
mshal
:
review+
|
Details |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
The options for build pools are currently "staging" and "production": https://github.com/mozilla/build-mozharness/blob/master/configs/builds/build_pool_specifics.py Taskcluster is basically a new pool. Let's add a new clause to that file omitting information that's not useful from taskcluster.
Assignee: nobody → dustin
Summary: Add an (empty) ' → Add an (empty) "taskcluster" build pool
Assignee | ||
Comment 2•9 years ago
|
||
/r/9065 - Bug 1166380: add 'taskcluster' build pool; r=mshal Pull down this commit: hg pull -r 6e253a21f3ccc722d668487b5334c0d213ec0e01 https://reviewboard-hg.mozilla.org/build-mozharness
Attachment #8607679 -
Flags: review?(mshal)
Comment 3•9 years ago
|
||
Comment on attachment 8607679 [details] MozReview Request: bz://1166380/dustin https://reviewboard.mozilla.org/r/9063/#review7697 Ship It!
Attachment #8607679 -
Flags: review?(mshal) → review+
Comment 4•9 years ago
|
||
Actually, does 'taskcluster' need to be added to buildbase.py:BuildOptionParser where it sets build_pools? Not sure if you need that for your use-case.
Assignee | ||
Comment 5•9 years ago
|
||
Good point - I'll re-draft.
Assignee | ||
Updated•9 years ago
|
Attachment #8607679 -
Flags: review+
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8607679 [details] MozReview Request: bz://1166380/dustin /r/9065 - Bug 1166380: add 'taskcluster' build pool; r=mshal /r/9137 - Bug 1166380: don't hard-code build pool names in buildbase.py Pull down these commits: hg pull -r d84645ed8805550daaaef9f40d509f1af0e6b287 https://reviewboard-hg.mozilla.org/build-mozharness
Attachment #8607679 -
Flags: review?(mshal)
Comment 8•9 years ago
|
||
Comment on attachment 8607679 [details] MozReview Request: bz://1166380/dustin https://reviewboard.mozilla.org/r/9063/#review7835 Ship It!
Attachment #8607679 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8607679 [details] MozReview Request: bz://1166380/dustin remote: https://hg.mozilla.org/build/mozharness/rev/2e2809fb05a9 remote: https://hg.mozilla.org/build/mozharness/rev/af1eee401f7f
Attachment #8607679 -
Flags: checked-in+
Assignee | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 10•9 years ago
|
||
mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/10ea0859a820
Comment 11•9 years ago
|
||
mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/10ea0859a820
Assignee | ||
Comment 12•9 years ago
|
||
:mshal noted that there are two places that still reference build_pool.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 13•9 years ago
|
||
testing the fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=07a51a6f4c36
Assignee | ||
Comment 14•9 years ago
|
||
Comment on attachment 8607679 [details] MozReview Request: bz://1166380/dustin /r/9065 - Bug 1166380: fix remaining build_pools occurrences; r=mshal Pull down this commit: hg pull -r b3f509ec95ee0a1340f458f340686d8428592b6f https://reviewboard-hg.mozilla.org/build-mozharness
Attachment #8607679 -
Flags: review+ → review?(mshal)
Assignee | ||
Comment 15•9 years ago
|
||
Using the right mozharness repo (hopefully): https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb554663cff4
Comment 16•9 years ago
|
||
Comment on attachment 8607679 [details] MozReview Request: bz://1166380/dustin https://reviewboard.mozilla.org/r/9063/#review7853 Looks good, hopefully try is happy...
Attachment #8607679 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 17•9 years ago
|
||
After several failures to specify the mozharness repo correctly, yes, try is reasonably happy (linux and android so far) https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb451f69d5b7 remote: https://hg.mozilla.org/build/mozharness/rev/0e6e9348c2ed ..and grafted to production.. remote: https://hg.mozilla.org/build/mozharness/rev/2ae240c4f588
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 18•9 years ago
|
||
There are places in buildbase that assume there's a symbol_server_host (and probably other keys). Traceback (most recent call last): File "./mozharness/scripts/fx_desktop_build.py", line 166, in <module> fx_desktop_build = FxDesktopBuild() File "./mozharness/scripts/fx_desktop_build.py", line 98, in __init__ super(FxDesktopBuild, self).__init__(**buildscript_kwargs) File "/home/worker/mozharness/mozharness/mozilla/building/buildbase.py", line 543, in __init__ self.query_build_env() File "/home/worker/mozharness/mozharness/mozilla/building/buildbase.py", line 785, in query_build_env replace_dict.update({"symbol_server_host": c['symbol_server_host']}) KeyError: 'symbol_server_host'
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 19•9 years ago
|
||
I'll test this in try at the same time.
Attachment #8610753 -
Flags: review?(mshal)
Assignee | ||
Comment 20•9 years ago
|
||
Comment on attachment 8610753 [details] [diff] [review] dont-fail.patch Never mind, that very much did not work. I'll just add the values to build_pool_specifics.py
Attachment #8610753 -
Flags: review?(mshal)
Assignee | ||
Comment 21•9 years ago
|
||
This has worked in try
Attachment #8610753 -
Attachment is obsolete: true
Attachment #8610825 -
Flags: review?(mshal)
Updated•9 years ago
|
Attachment #8610825 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 22•9 years ago
|
||
Comment on attachment 8610825 [details] [diff] [review] symbol-and-stage-for-tc.patch remote: https://hg.mozilla.org/build/mozharness/rev/92af19b51890
Attachment #8610825 -
Flags: checked-in+
Assignee | ||
Updated•9 years ago
|
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 23•9 years ago
|
||
Attachment #8607679 -
Attachment is obsolete: true
Attachment #8620333 -
Flags: review+
Attachment #8620334 -
Flags: review+
Assignee | ||
Comment 24•9 years ago
|
||
Assignee | ||
Comment 25•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•