1166425 - Failed to load module resource://gre/modules/devtools/gcli/util/filesystem.js in Firefox for Android

Status: RESOLVED INCOMPLETE

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[Nick Alexander :nalexander [he/him]]

Starting the debugger in Firefox for Android spews a Failed to load module error (log below).  This appears to be a problem requesting the "Home" directory.  This just doesn't make sense on Android at all, so I'm not sure what should be done.  Make it a lazy accessor?  Audit consumers and make them do better things on Android?

Code is at:

https://dxr.mozilla.org/mozilla-central/source/toolkit/devtools/gcli/source/lib/gcli/util/filesystem.js?from=filesystem.js#38

|adb logcat| output:

I Gecko(14969)                console.error: 
E GeckoConsole(14969)         [JavaScript Error: "Failed to load module gcli/types/file: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/util/filesystem.js :: <TOP_LEVEL> :: line 38"  data: no]"]
I Gecko(14969)                  Failed to load module gcli/types/file: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/util/filesystem.js :: <TOP_LEVEL> :: line 38"  data: no]
I Gecko(14969)                console.error: 
E GeckoConsole(14969)         [JavaScript Error: "@undefined:38:NaN
E GeckoConsole(14969)         @resource://gre/modules/devtools/gcli/util/filesystem.js:38:16
E GeckoConsole(14969)         @resource://gre/modules/devtools/gcli/util/fileparser.js:22:18
E GeckoConsole(14969)         @resource://gre/modules/devtools/gcli/types/fileparser.js:19:17
E GeckoConsole(14969)         @resource://gre/modules/devtools/gcli/types/file.js:40:18
E GeckoConsole(14969)         exports.createSystem/system.addItemsByModule/</options.loader@resource://gre/modules/devtools/gcli/system.js:166:20
E GeckoConsole(14969)         exports.createSystem/loadModule@resource://gre/modules/devtools/gcli/system.js:113:30
E GeckoConsole(14969)         exports.createSystem/system.load/promises<@resource://gre/modules/devtools/gcli/system.js:211:16
E GeckoConsole(14969)         exports.createSystem/system.load@resource://gre/modules/devtools/gcli/system.js:209:22
E GeckoConsole(14969)         GcliActor<._getRequisition@resource://gre/modules/devtools/server/actors/gcli.js:253:32
E GeckoConsole(14969)         GcliActor<.specs<@resource://gre/modules/devtools/server/actors/gcli.js:96:12
E GeckoConsole(14969)         actorProto/</handler@resource://gre/modules/devtools/server/protocol.js:1006:19
E GeckoConsole(14969)         DSC_onPacket@resource://gre/modules/devtools/server/main.js:1456:15
E GeckoConsole(14969)         DebuggerTransport.prototype._onJSONOb
I Gecko(14969)                  @undefined:38:NaN
I Gecko(14969)                @resource://gre/modules/devtools/gcli/util/filesystem.js:38:16
I Gecko(14969)                @resource://gre/modules/devtools/gcli/util/fileparser.js:22:18
I Gecko(14969)                @resource://gre/modules/devtools/gcli/types/fileparser.js:19:17
I Gecko(14969)                @resource://gre/modules/devtools/gcli/types/file.js:40:18
I Gecko(14969)                exports.createSystem/system.addItemsByModule/</options.loader@resource://gre/modules/devtools/gcli/system.js:166:20
I Gecko(14969)                exports.createSystem/loadModule@resource://gre/modules/devtools/gcli/system.js:113:30
I Gecko(14969)                exports.createSystem/system.load/promises<@resource://gre/modules/devtools/gcli/system.js:211:16
I Gecko(14969)                exports.createSystem/system.load@resource://gre/modules/devtools/gcli/system.js:209:22
I Gecko(14969)                GcliActor<._getRequisition@resource://gre/modules/devtools/server/actors/gcli.js:253:32
I Gecko(14969)                GcliActor<.specs<@resource://gre/modules/devtools/server/actors/gcli.js:96:12
I Gecko(14969)                actorProto/</handler@resource://gre/modules/devtools/server/protocol.js:1006:19
I Gecko(14969)                DSC_onPacket@resource://gre/modules/devtools/server/main.js:1456:15
I Gecko(14969)                DebuggerTransport.prototype._onJSONObjectReady/<@resour

Comment 1

[Nick Alexander :nalexander [he/him]]

jryans: these types of tickets seem to be your bailiwick.  Can you redirect as appropriate?

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I'm going to guess it's another fallout from the GCLI runAt change...  Although the "home" export did not change recently, runAt might have caused it to run on Android where it did not before.

Making the "home" export lazy is likely enough to fix it, but we might need to trace the callers to be sure.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Nick, does this block the debugger from working, or it spews an error and keeps working anyway?

Comment 4

[Joe Walker [:jwalker]]

I think the best solution here is for toolkit/devtools/gcli/commands/index.js to say something like this around line 50:

    if (fennec) {
      exports.baseModules = exports.baseModules.filter(module => module != "gcli/types/file");
    }

Comment 5

[Nick Alexander :nalexander [he/him]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #3)
> Nick, does this block the debugger from working, or it spews an error and
> keeps working anyway?

It appears to work after this.  I tested in both a custom Nightly build and the most recently available Developer Edition.

Comment 6

[Joe Walker [:jwalker]]

(In reply to Joe Walker [:jwalker] (overloaded - needinfo me or ping on irc) from comment #4)
> I think the best solution here is for
> toolkit/devtools/gcli/commands/index.js to say something like this around
> line 50:
> 
>     if (fennec) {
>       exports.baseModules = exports.baseModules.filter(module => module !=
> "gcli/types/file");
>     }

Let me update that as a result of bug 1166835:

     if (fennec || process !== childProcess) {
       exports.baseModules = exports.baseModules
                     .filter(module => module != "gcli/types/file");
     }

Comment 8

[Firefox Bug Husbandry Bot]

Per bug 1491875, this component has been closed, and the affected code is being removed from Firefox. Closing this bug as incomplete.