1166482 - troubleshooting account, identity information is missing

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[Dan Pernokis]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150513174244

Steps to reproduce:

Run Thunderbird's TROUBLESHOOTING page and click "Include Account Names".  Then go to the MAIL AND NEWS ACCOUNTS section.


Actual results:

The Account Names turn on as one would expect for each account, but there is no info about the entities.  For accounts with multiple entities, all we see is a repetitive list of mail servers and, under status, "false" for all except first entity (which says "true").  



Expected results:

Since I clicked "Include Account Names", I would expect to see the Entity names as well.  Otherwise:
If they all use same server, then why repeat the same info?
If they use different servers, then how do I know who uses what?

[[ If anyone is going to tackle this, I would suggest a second checkbox to "Include Entity Names" so accounts can be shown (as now) without compromising actual email user names. ]]

Comment 1

[:aceman]

Yeah, this could be useful.

Comment 2

[:aceman]

Attachment: patch

Would this work?

Comment 3

[Dan Pernokis]

Ace, if you're talking to me, I don't know the code to say definitely yes, but based on the logic flow I think I see, then I think it probably does.

(Is any of this code temporarily installable for me to test?)

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 8609855 [details] [diff] [review]
patch

Review of attachment 8609855 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good if you get rid of the duplicated info.

::: mail/components/about-support/content/aboutSupport.xhtml
@@ +227,5 @@
> +            </th>
> +
> +            <th class="data-private">
> +              &aboutSupport.identityEmail;
> +            </th>

I think this isn't needed. All we need is (or should be) in the identityName

::: mail/locales/en-US/chrome/messenger/aboutSupportMail.dtd
@@ +16,4 @@
>  <!ENTITY aboutSupport.accountsConnSecurity "Connection security">
>  <!ENTITY aboutSupport.accountsAuthMethod "Authentication method">
>  <!ENTITY aboutSupport.accountsDefault "Default?">
> +<!ENTITY aboutSupport.identityName "Identity name">

... and then this should just be "Identity"

Comment 5

[:aceman]

Yeah, I made this having bug 318495 in mind. In its state state at the time, identityName does not necessarily contain the email.

Comment 6

[:aceman]

Attachment: patch v1.1

On the other hand, the user should have enough hints from the identityName alone.

Comment 7

[Dan Pernokis]

Thanks, Ace!

Comment 8

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/8f8d9edfa43e

Comment 9

[Dan Pernokis]

Any idea when (in the calendar) this new feature will be released?  (We're currently at TB 38, and TB 41 sounds a long way off.)

Comment 10

[:aceman]

Actually TB41 is just around the corner (it is in beta channel now, if you wanted to try it). However, that will never be released as stable version. The next stable version released to users will be TB 45. That one is about 30 weeks away.