Closed
Bug 1166615
Opened 9 years ago
Closed 9 years ago
Rocketbar should blur the input manually
Categories
(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)
Firefox OS Graveyard
Gaia::System::Browser Chrome
ARM
Gonk (Firefox OS)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timdream, Assigned: timdream)
References
Details
Attachments
(1 file)
With bug 1122463 we will no longer blur the input if the submit event is default prevented, which is exactly what https://github.com/mozilla-b2g/gaia/blob/01938468cf518009e08262532c6dfc56b6cb2210/apps/system/js/rocketbar.js#L582-L583 did. Fortunately this behavior is protected by Gij tests so I will patch the call here for it to do |this.input.blur()| on it's own.
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8607969 [details] [review] [gaia] timdream:rocketbar-blur > mozilla-b2g:master Etienne, Could you review this? Please read comment 0 for the context.
Attachment #8607969 -
Flags: review?(etienne)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8607969 [details] [review] [gaia] timdream:rocketbar-blur > mozilla-b2g:master glad this was covered :)
Attachment #8607969 -
Flags: review?(etienne) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Comment 4•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/daea64676b89a29a8e0ffbca3c1bc371e632424b
|
|
||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•