1166679 - Implement GetMessage function

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Implement GetMessage function

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: bug-1166679-mc.patch

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: bug-1166679-mc.patch

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1166679 - Implement GetMessage function

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1166679 - Implement GetMessage function

Comment 5

[Ben Tian (inactive)]

Comment on attachment 8649176 [details] [diff] [review]
Bug 1166679 - Implement GetMessage function

Review of attachment 8649176 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed.

::: dom/bluetooth/bluedroid/BluetoothMapSmsManager.cpp
@@ +845,5 @@
> +BluetoothMapSmsManager::HandleSmsMmsGetMessage(const ObexHeaderSet& aHeader)
> +{
> +  MOZ_ASSERT(NS_IsMainThread());
> +
> +  BluetoothService* bs = BluetoothService::Get();

Ensure |bs| is non-nullptr.

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8649176 [details] [diff] [review]
Bug 1166679 - Implement GetMessage function

Review of attachment 8649176 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/bluedroid/BluetoothMapSmsManager.cpp
@@ +850,5 @@
> +
> +  InfallibleTArray<BluetoothNamedValue> data;
> +  nsString name;
> +  aHeader.GetName(name);
> +  BT_APPEND_NAMED_VALUE(data, "name", name);

Maybe it will be better to call "handle" instead of "name" here.

Field/Header       Name               Value
Header                Name               Message Handle

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1166679 - Implement GetMessage function, r=btian

Comment 8

[Ben Tian (inactive)]

Revise flag to feature-b2g: 2.2r+ since MAP is required bluetooth feature for 2.2r.

Comment 9

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1166679 - Implement GetMessage function, r=btian (m-c)

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/e03440d6f249

Comment 11

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1166679 - Implement GetMessage function, r=btian (v2.2r)

Comment 12

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e995c445f70a

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e03440d6f249

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/1930fdae016a

Comment 15

[Carsten Book [:Tomcat]]

sorry i had to back this out in https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/67d81601af97

seems one change here was causing a bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=6599&repo=mozilla-b2g37_v2_2r

Comment 16

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I've found that Bug 1195710 v2.2r patch cause this bustage. I will fix it in bug 1195710.

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/d5f192858ca3