1166704 - If the Pocket button is hidden, there's no visual feedback displayed for clicking the save button from Reader View

Status: RESOLVED WORKSFORME

(Firefox :: Pocket, defect)

Description

[Andrei Vaida [:avaida]]

Reproducible on:
Beta 38.0.5b3-build1 (20150518141916)

Affected platforms:
Window 7 (x64), Mac OS X 10.9.5, Ubuntu 14.04 (x64)

Preconditions:
* user is logged into Pocket
* Reader View is enabled

Steps to reproduce:
1. Click menu [≡] → Customize.
2. Drag & drop the Pocket button from the toolbar (default location) to the "Additional Tools and Features" section from the Customize window → click [Exit Customize].
3. Open a Reader View-compatible page, e.g. http://www.bbc.com/autos/story/20150519-what-is-the-best-car-to-drive-around-the-world
4. Click the [Enter Reader View] button from the Location Bar.
5. From Reader View's controls bar, click the Pocket button.

Expected result:
* Hiding the Pocket button does NOT disable/hide the feature.
* If the user clicks the save button from Reader View while the Pocket button is hidden, a Pocket confirmation panel is displayed stating the the page was saved to Pocket.

Actual result:
* Clicking the button has no visual feedback.
* Looking through the Network logs, there are also no save request sent to Pocket.

Comment 1

[Justin Dolske [:Dolske]]

I can't reproduce this -- when the main Pocket button is removed from UI, the RV button is also removed.

Perhaps you were hitting the case bug 1167328 describes? We only check the main Pocket button visibility when RV first opens.

Comment 2

[Andrei Vaida [:avaida]]

(In reply to Justin Dolske [:Dolske] from comment #1)
> I can't reproduce this -- when the main Pocket button is removed from UI,
> the RV button is also removed.
> 
> Perhaps you were hitting the case bug 1167328 describes? We only check the
> main Pocket button visibility when RV first opens.

This is indeed no longer reproducible as of RC 38.0.5-build3 (20150521175336) and RC 38.0.5-build4 (20150525141253). Closing.