Closed Bug 1167117 Opened 9 years ago Closed 9 years ago

[building block] smart-modal-dialog should line all buttons as one line.

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: johnhu, Assigned: johnhu)

Details

Attachments

(2 files)

put all buttons at one line.
61 bytes, text/x-github-pull-request
suchiu
: review+
Details | Review
[gaia] huchengtw-moz:bug-1167117-update-smart-modal-dialog > mozilla-b2g:master
46 bytes, text/x-github-pull-request
johnhu
: review+
Details | Review 
smart modal dialog wraps buttons as multiple line. We should make it only one line.
Sung,

Please review this patch. Thanks.
Attachment #8608624 - Flags: review?(suchiu)
Assignee: nobody → im
I will create a patch here to update the smart-system.
Comment on attachment 8608624 [details] [review]
put all buttons at one line.

This patch is great!
Attachment #8608624 - Flags: review?(suchiu) → review+
merge to smart-modal-dialog:
https://github.com/smart-components/smart-modal-dialog/pull/6

keep it opening for reminding me to create a patch for smart-system.
Comment on attachment 8609936 [details] [review]
[gaia] huchengtw-moz:bug-1167117-update-smart-modal-dialog > mozilla-b2g:master

Since this patch is just update the bower component, I carry r+ from bower component.
Attachment #8609936 - Flags: review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: