Closed
Bug 1167390
Opened 9 years ago
Closed 9 years ago
Mark nsNodeWeakReference::mNode as MOZ_NON_OWNING_REF
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
Details
Attachments
(1 file)
|
660 bytes,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8609011 -
Flags: review?(jst)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8609011 -
Flags: review?(jst) → review?(ehsan)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8609011 [details] [diff] [review] Mark nsNodeWeakReference::mNode as MOZ_NON_OWNING_REF Review of attachment 8609011 [details] [diff] [review]: ----------------------------------------------------------------- Olli is a better reviewer for this one.
Attachment #8609011 -
Flags: review?(ehsan) → review?(bugs)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8609011 [details] [diff] [review] Mark nsNodeWeakReference::mNode as MOZ_NON_OWNING_REF Yes, this is the whole point of the weakref thing.
Attachment #8609011 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → michael
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f2a8c2a5878b
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•