1168166 - IDB should check mozStorageConnection::SetGrowthIncrement() return for NS_ERROR_FILE_TOO_BIG

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

IndexedDB currently calls mozIStorageConnection::SetGrowthIncrement() to grow the sqlite in larger chunks.  It only does this on desktop, though, because SetGrowthIncrement() is constrainted not to work on mobile.  Looking at the comment for this method, though:

  To conserve memory on systems short on storage space, this function will have no effect on mobile devices or if less than 500MiB of space is left available.

It also fails if the desktop machine has <= 500MiB of disk left.

This means the current IDB code will always error out when the disk hits this threshold.  IDB should probably check for NS_ERROR_FILE_TOO_BIG and ignore it since the growth increment is mainly an optimization.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Ben, did you intend this behavior?

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Hm, no, that looks bad.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Trivial fix

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ab4fcd2c9ca6

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

This should get backported to aurora.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ab4fcd2c9ca6