1168309 - [FFOS] Gonk's PDM cannot enter dormant state.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Blake Wu [:bwu][:blakewu]]

When playing some videos from browser and pushing the home key, PDM doesn't enter dormant and codec is not released.

Comment 1

[Blake Wu [:bwu][:blakewu]]

User experience impacted: 
If user watch video from browsers and then push the home key to play a video file in video app, video app will show "Another app is currently using the video player".

Comment 2

[Blake Wu [:bwu][:blakewu]]

This should be caused by the Bug 1163458.
The root cause is MOZ_GONK_MEDIACODEC is not defined dom/media, so READER_DORMANT_HEURISTIC will not be defined in [1] and subsequently MediaFormatReader's IsDormantNeeded()[2] returns false. 


[1]https://dxr.mozilla.org/mozilla-central/source/dom/media/MediaFormatReader.h#20
[2]https://dxr.mozilla.org/mozilla-central/source/dom/media/MediaFormatReader.cpp#1288

Comment 3

[Blake Wu [:bwu][:blakewu]]

Attachment: Add-the-define-MOZ_GONK_MEDIACODEC-to-dom/media.patch

Root cause:
Per comment 2. 

Solution:
Add the define, MOZ_GONK_MEDIACODEC, to dom/media.

Comment 4

[Blake Wu [:bwu][:blakewu]]

Attachment: Add-the-define-MOZ_GONK_MEDIACODEC-to-dom-media.patch

Thanks for cpearce's review! 
Carry r+ from cpearce.

Comment 5

[Blake Wu [:bwu][:blakewu]]

Try server: 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=44583ec38e13

Comment 6

[Blake Wu [:bwu][:blakewu]]

Test results are all green.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a3a3e00caaff

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a3a3e00caaff

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a3a3e00caaff