1168324 - Migrate test_sms_contact_match.py to Gij

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Original test: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_contact_match.py

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] JohanLorenzo:bug-1168324 > mozilla-b2g:master

Comment 2

[Johan Lorenzo [:jlorenzo]]

I have another problem with the Contact storage. No contact was detected when I entered his name in the recipient list[1]. The contact storage seems to be used after launching the app and after setting the message storage[2]. Is there any other condition I should respect to use it, Oleg?

[1] https://github.com/mozilla-b2g/gaia/pull/30345/files#diff-ec1e85749cbb823085766fba8037051aR328 
[2] https://github.com/mozilla-b2g/gaia/pull/30345/files#diff-ec1e85749cbb823085766fba8037051aR290

Comment 3

[Oleg Zasypkin [:azasypkin]]

Looks like it's because of the fact that our contacts mock is very simple and doesn't support "contains" filter operation yet (see the only supported search strategy at [1]);

We usually implement bare minimum and then add more cases only when needed.

So we need one more search strategy for "contains" filter operation, let me know if you want me to assist here - would be happy to provide the patch.

[1] https://github.com/mozilla-b2g/gaia/blob/9e10483c5808f94f4a0a9f6afe30aae2c5b42b4c/apps/sms/test/marionette/mocks/mock_navigator_moz_contacts.js#L62

Comment 4

[Oleg Zasypkin [:azasypkin]]

I went ahead and created a gist with updated filter strategy chooser that should help [1]. Just make sure that mock contact contains both "name" and "givenName/familyName" if you search by name.

[1] https://gist.github.com/azasypkin/e9f890e0f5728a707d5d

Comment 5

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8613485 [details] [review]
[gaia] JohanLorenzo:bug-1168324 > mozilla-b2g:master

Works great! I'll rebase the patch once bug 1168118 lands. In the meantime, the last commit shows the test migration and the contact mocks changes.

Comment 6

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8613485 [details] [review]
[gaia] JohanLorenzo:bug-1168324 > mozilla-b2g:master

PR for bug 1168118 is r+'ed, could you please rebase this PR on master once bug 1168118 lands and ask review again?

Thanks!

Comment 7

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8613485 [details] [review]
[gaia] JohanLorenzo:bug-1168324 > mozilla-b2g:master

Rebased. TH still green in Gij.

Comment 8

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8613485 [details] [review]
[gaia] JohanLorenzo:bug-1168324 > mozilla-b2g:master

LGTM, just few nits at GitHub.

Thanks!

Comment 9

[Johan Lorenzo [:jlorenzo]]

Gij is showing green, no new intermittent to report: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=b659b0a990673ca5afece76b88289e727ed063dc

Landed in master at: https://github.com/mozilla-b2g/gaia/commit/4cbd2316b5b08f384bfe806cfd5f67c128e82462

Comment 10

[Johan Lorenzo [:jlorenzo]]

Side note: JSHint was showing orange because of another commit than this one.