1168344 - Improve version handling in bluetoothd

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

We should push version handling in bluetoothd into the makefile to make the source code easier to read.

We should also add documentation for porting and versioning.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request

Some improvements to version handling before we land GATT support.

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I have a question for 'Bug 1168344: Remove version protections in AVRCP module' and one suggestion for 'Bug 1168344: Handle Android versions in makefile'.

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Shawn Huang [:shawnjohnjr] from comment #2)
> I have a question for 'Bug 1168344: Remove version protections in AVRCP
> module' and one suggestion for 'Bug 1168344: Handle Android versions in
> makefile'.

Thanks Shawn. I put the answers into the Github pull request.

Since it's r+'ed, I'll update the pull request and land the changes later today. Ping me to interfere.

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8610523 [details] [review]
Github pull request

Updated Github pull request

  - call CLEAR_VARS near the top of the makefile
  - fixed makefile error string

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/platform_system_bluetoothd/commit/4132c66e4bc78e119eb1cf34b6cf77db8e714e9a