1168530 - Add context menu option for "Show password"

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

The original plan was to have this as part of "Edit login" > "Show password" but we should surface this earlier and make it easier, because this is probably what people do *most* of the time.

This bug is to add "Show password" to the context menu, and when tapping on that, close the first context menu and then open a new dialog that is just the text of the password.

Comment 1

[Chenxia Liu [:liuche]]

Attachment: Screenshot: Show password dialog

Hm, I'm not sure how I feel about this. I'd prefer just the single line dialog, but it's not long-pressable without a bit of hacking.

Comment 2

[Chenxia Liu [:liuche]]

Attachment: Screenshot: Show password dialog v2

Comment 3

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1168530 - Add context menu option for "Show password". r=ally

Bug 1168530 - Add context menu option for "Show password". r=ally

Comment 4

[Chenxia Liu [:liuche]]

Friendly review ping - this should be really quick.

Comment 5

[Allison Naaktgeboren :ally]

Comment on attachment 8614455 [details]
MozReview Request: Bug 1168530 - Add context menu option for "Show password". r=ally

https://reviewboard.mozilla.org/r/9961/#review9145

Ship It!

::: mobile/android/chrome/content/aboutPasswords.js:181
(Diff revision 1)
> +                // Corresponds to "Copy password" button.

I still really dislike the hardcoded button order. Thank you for the comment

::: mobile/android/locales/en-US/chrome/aboutPasswords.properties:5
(Diff revision 1)
> +passwordsMenu.showPassword=Show password

Doesn't look like anything here would be incorrect after the rename from about:passwords to about:logins .

Comment 6

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/fx-team/rev/01a6f68c4e53

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/01a6f68c4e53