Closed Bug 1168569 Opened 9 years ago Closed 9 years ago

Incorrect color for the day-off part of the selected day in week view

Categories

(Calendar :: Calendar Frontend, defect)

Product:
Calendar
Component:
Calendar Frontend
Version:
Lightning 4.0.0.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
4.0.0.1

People

(Reporter: bv1578, Assigned: bv1578)

Details

Attachments

(1 file, 1 obsolete file)

patch - v2
1.57 KB, patch
bv1578
: review+
Fallen
: approval-calendar-aurora+
Fallen
: approval-calendar-beta+
Fallen
: approval-calendar-esr+
Details | Diff | Splinter Review 
The day-off part of the selected day, in week view, currently has the color of the "today" day instead of a specific color.
Attached patch patch - v1 (obsolete) — — Splinter Review 
The patch should fix.
Attachment #8610802 - Flags: review?(richard.marti)
Comment on attachment 8610802 [details] [diff] [review]
patch - v1

r+ with changing the [systemcolors] variable --viewDayBoxOffSelectedBackground: rgba(0, 0, 0, .1); to rgba(0, 0, 0, .2). Without this the selected offtime isn't good visible without this change.
Attachment #8610802 - Flags: review?(richard.marti) → review+
Attached patch patch - v2 — — Splinter Review 
(In reply to Richard Marti (:Paenglab) from comment #2)

> r+ with changing the [systemcolors] variable
> --viewDayBoxOffSelectedBackground: rgba(0, 0, 0, .1); to rgba(0, 0, 0, .2).
> Without this the selected offtime isn't good visible without this change.

Thanks, I had forgotten the "systemcolors" part.
Attachment #8610802 - Attachment is obsolete: true
Attachment #8611387 - Flags: review+
Keywords: checkin-needed
Comment on attachment 8611387 [details] [diff] [review]
patch - v2

Review of attachment 8611387 [details] [diff] [review]:
-----------------------------------------------------------------

The bug is also in beta.
Attachment #8611387 - Flags: approval-calendar-beta?(philipp)
Attachment #8611387 - Flags: approval-calendar-aurora?(philipp)
Comment on attachment 8611387 [details] [diff] [review]
patch - v2

Ok, please push soon, I'm not sure if there will be another beta build. When pushing to beta, please push to default and THUNDEBIRD_38_VEBRANCH.
Attachment #8611387 - Flags: approval-calendar-release+
Attachment #8611387 - Flags: approval-calendar-beta?(philipp)
Attachment #8611387 - Flags: approval-calendar-beta+
Attachment #8611387 - Flags: approval-calendar-aurora?(philipp)
Attachment #8611387 - Flags: approval-calendar-aurora+
Pushed to
comm-central: http://hg.mozilla.org/comm-central/rev/00fc2020a1a1
comm-aurora:  http://hg.mozilla.org/releases/comm-aurora/rev/0c7925f2a61b
comm-release: http://hg.mozilla.org/releases/comm-release/rev/dca7454ed8b4
comm-beta:    http://hg.mozilla.org/releases/comm-beta/rev/b212707c7347
              http://hg.mozilla.org/releases/comm-beta/rev/53d77f754b37
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.1
Version: Trunk → Lightning 4.1
Is fixed for 4.0 too (THUNDEBIRD_38_VEBRANCH).
Keywords: checkin-needed
Version: Lightning 4.1 → Lightning 4.0
OK, thanks.
So, also the target milestone should be 4.0, is it right?
Target Milestone: 4.1 → 4.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: