1168578 - GTK3: Checkboxes do not indicate hover or pressed states

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Andrew Comminos [:acomminos]]

Using GTK 3.14, checkboxes in forms do not show any visual indication that they are being pressed or hovered over.

See gtk3-widget-factory for correct behaviour.

Comment 1

[Jan Alexander Steffens [:heftig]]

The proper state flags to use would be GTK_STATE_FLAG_PRELIGHT for hover and GTK_STATE_FLAG_ACTIVE for being pressed.

As noted in bug 1073117, check boxes had no active state before 3.14, where ACTIVE means checked. Since 3.14, check boxes can be active, and the checked state has been moved to CHECKED.

Comment 2

[Andrew Comminos [:acomminos]]

Attachment: Use widget state in GTK3 toggles' style context.

This works as an unintrusive solution, but it might be worth moving the widget state setup to nsNativeThemeGTK instead.

Any thoughts would be appreciated; thanks!

Comment 3

[Karl Tomlinson (:karlt)]

Comment on attachment 8611472 [details] [diff] [review]
Use widget state in GTK3 toggles' style context.

This looks good to me, thanks.

(In reply to Andrew Comminos [:acomminos] from comment #2)
> but it might be worth moving the
> widget state setup to nsNativeThemeGTK instead.

I'm not sure.  If it means lots of special cases in nsNativeThemeGTK it wouldn't be a win.

> Any thoughts would be appreciated; thanks!

I wonder why we have both GtkWidgetState::depressed and the selected parameter.  I don't know what distinction there is between those, if any.

Comment 4

[Andrew Comminos [:acomminos]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=266985552c95

(In reply to Karl Tomlinson (ni?:karlt) from comment #3)
> I wonder why we have both GtkWidgetState::depressed and the selected
> parameter.  I don't know what distinction there is between those, if any.

They're inconsistent at the moment, but GtkWidgetState::depressed appears to be intended to describe activated toggle-able widgets. Currently the selected state is fetched from a 'flags' argument set in nsNativeThemeGTK::GetGtkWidgetAndState instead.

Comment 5

[Andrew Comminos [:acomminos]]

Updated try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c221c198ec44

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/73103204e24e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/73103204e24e