1168730 - we need to add a new keyword 'led' for KeyLayoutMap

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[viral [:viralwang]]

we expect we can use Generic.kl for keycode mapping but we can load it since there's a new keyword 'led'
we will get the error log as below

E/KeyLayoutMap(16416): /system/usr/keylayout/Generic.kl:431: Expected keyword, got 'led'.

Comment 1

[viral [:viralwang]]

Attachment: add 'led' for KeyLayoutMap scan code

Hi Michael,

I only update partial code for the new keyword 'led', then we can use the Generic.kl file directly.

Comment 2

[Michael Wu [:mwu]]

Is there a git commit on the Android side which this corresponds to? Or a set of commits?

Comment 3

[viral [:viralwang]]

Hi Michael,

Most of changes come from this commit: https://android.googlesource.com/platform/frameworks/native/+/74bdd2e7ceabd3c9e74ccf7c2e6bd3dae27ca497
Android move it to KeycodeLabels.h in following commit but I think we only need few things to make it work.
https://android.googlesource.com/platform/frameworks/native/+/872db4f11e407accccba9d37c335ef7e3597eba4

Thank you :)

Comment 4

[Michael Wu [:mwu]]

Comment on attachment 8611075 [details] [diff] [review]
add 'led' for KeyLayoutMap scan code

Review of attachment 8611075 [details] [diff] [review]:
-----------------------------------------------------------------

Ok. Please put the information about where you got this in the commit message.

We should probably just drop in a new copy of Android input code at some point and pickup all the updates.

Comment 5

[viral [:viralwang]]

Attachment: add 'led' for KeyLayoutMap scan code (v2)

update commit message for landing

Comment 6

[viral [:viralwang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9241c0a76f7d
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9e7e4c0fc4b

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/bdc2ca02b080

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bdc2ca02b080

Comment 9

[viral [:viralwang]]

Hi Josh,

I think we need this fix for v2.2 since we can't use power key to wake up flame-l with v2.2 now.
With this gecko fix, we can use correct key mapping for flame-l.
Thank you :)

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please request b2g37 approval on this patch when you get a chance.

Comment 11

[viral [:viralwang]]

Comment on attachment 8614504 [details] [diff] [review]
add 'led' for KeyLayoutMap scan code (v2)

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): NA
User impact if declined: we need this fix for v2.2 since we can't use power key to wake up flame-l with v2.2 now. With this gecko fix, we can use correct key mapping for flame-l.
Testing completed: local test is fine.
Risk to taking this patch (and alternatives if risky): Low. 
String or UUID changes made by this patch: NA

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/515e59651b64