11691 - [infinite loop] bugs - nsPop3Protocol.cpp

Status: VERIFIED FIXED

(MailNews Core :: Networking, defect, P3)

Description

[Jay Patel [:jay]]

Analysis of the code has determined possible infinite loop
or problem in the code below.  See bug
http://bugzilla.mozilla.org/show_bug.cgi?id=11588
for more information

  nsPop3Protocol.cpp:530: warning: unsigned value < 0 is always 0
  nsPop3Protocol.cpp:561: warning: unsigned value < 0 is always 0
  nsPop3Protocol.cpp:665: warning: unsigned value < 0 is always 0
  nsPop3Protocol.cpp:1027: warning: unsigned value < 0 is always 0
  nsPop3Protocol.cpp:1133: warning: unsigned value < 0 is always 0
  nsPop3Protocol.cpp:1301: warning: unsigned value < 0 is always 0
  nsPop3Protocol.cpp:1412: warning: unsigned value < 0 is always 0

Comment 1

[lchiang]

correcting component to mailnews.

Comment 2

[Scott MacGregor]

The line numbers are now out of date due to code modifications in the file. How
did we get these lines numbers in the first place? I couldn't find them in
slamm's warning page nor by looking at a linux build log. I ask, so I can try to
trigger them again to figure out the new line numbers I should look at. Thanks.

Comment 3

[Scott MacGregor]

Jay/Chris, how did you guys generate these warnings? This file has changed a lot
since the warnings were generated so the line numbers are all different. I
wanted to generate the warnings again so I could match it up against the current
contents of the file.

Comment 4

[chris hofmann]

check bug 11588 for info on how to get a linux warning with the current line no.
use -W

Comment 5

[Scott MacGregor]

I've fixed these problems in nsPop3Protocol.cpp. I'll be checking it in today
when the tree opens so no need to triage this bug further.

Comment 6

[Scott MacGregor]

I checked in the fix for this today.

Comment 7

[lchiang]

Par, can you verify at your convenience?

Comment 8

[ppandit]

VERIFIED based on code inspection of nsPop3Protocol.cpp.

Par