Closed
Bug 1169232
Opened 9 years ago
Closed 9 years ago
[gtk3] White text on grey background on notification toolbar.
Categories
(Core :: Widget: Gtk, defect)
Core
Widget: Gtk
Tracking
()
RESOLVED
FIXED
mozilla41
People
(Reporter: glandium, Assigned: stransky)
References
()
Details
Attachments
(2 files)
587.66 KB,
image/png
|
Details | |
1.25 KB,
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
I assume this is true for other info bars, although it doesn't happen for the telemetry thing. See attached screenshot.
Reporter | ||
Comment 1•9 years ago
|
||
This is the CSS fragment corresponding to the style of those infobars: http://hg.mozilla.org/mozilla-central/file/baa9c64fea6f/toolkit/themes/linux/global/notification.css#l7 So InfoText must be wrong.
Assignee | ||
Comment 2•9 years ago
|
||
1011 gtk_style_context_add_class(style, GTK_STYLE_CLASS_TOOLTIP); 1012 gtk_style_context_get_background_color(style, GTK_STATE_FLAG_NORMAL, &color); 1013 sInfoBackground = GDK_RGBA_TO_NS_RGBA(color); 1014 gtk_style_context_get_color(style, GTK_STATE_FLAG_NORMAL, &color); 1015 sInfoText = GDK_RGBA_TO_NS_RGBA(color); 1016 g_object_unref(style);
Updated•9 years ago
|
tracking-e10s:
--- → m8+
Keywords: polish
Assignee | ||
Comment 3•9 years ago
|
||
IMHO it should also use tooltip background (which is black) or choose a different text color.
Assignee | ||
Comment 4•9 years ago
|
||
Actually the bug is caused by transparent tooltip background color which is defined by Gtk3 themes.
Assignee | ||
Comment 5•9 years ago
|
||
Assignee: nobody → stransky
Attachment #8613482 -
Flags: review?(karlt)
Assignee | ||
Comment 6•9 years ago
|
||
Unfortunately it breaks all kind of notifications like addon updates and so.
Summary: [gtk3] White text on grey background for e10s post activation info bar. → [gtk3] White text on grey background on notification toolbar.
Updated•9 years ago
|
Attachment #8613482 -
Flags: review?(karlt) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8012d33b7c71
Assignee | ||
Updated•9 years ago
|
Keywords: polish → checkin-needed
https://hg.mozilla.org/mozilla-central/rev/92c770d9b2cc
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•