1169241 - Wrong styling for the onboarding tour footer links

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Cornel Ionce [:noni] [Hubs QA]]

Affected builds:
- Firefox 40.0a2 Aurora, build ID: 20150528004000
- Firefox 41.0a1 Nightly, build ID: 20150527135446
Affected platforms: Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit.

STR:
1. Open Firefox using a clean profile;
2. Open a newtab page;
3. Visit the "More about new Tab" or "About your privacy" links from the page tour.

Results:
The styling is wrong after the links are visited, the links become black.

Screenshot: http://i.imgur.com/mNHCPcM.png

Comment 1

[Marina Samuel [:emtwo]]

Ed, this issue should be resolved by bug 1172987. Would it make sense to uplift those fixes to Aurora to fix this?

Comment 2

[Ed Lee :Mardak]

The black color doesn't seem to be fixed on Nightly or Aurora by bug 1172987. That bug has been uplifted.

Comment 3

[Justin Crawford [:hoosteeno] [:jcrawford]]

Hi, I'd like to give this bug a shot. Quick questions:

1) What is the _expected_ color of visited links? Same as un-visited links?
2) In my freshly built copy of nightly, the link to "Privacy Notice" seems to be browser-default blue, rather than #4A90E2 (the blue color of other un-visited links in the intro). When visited, it is browser-default purple. It's also underlined. Shall I apply the same link styles to inline links throughout?

Comment 4

[Marina Samuel [:emtwo]]

(In reply to Justin Crawford [:hoosteeno] [:jcrawford] from comment #3)
> Hi, I'd like to give this bug a shot. Quick questions:
> 
> 1) What is the _expected_ color of visited links? Same as un-visited links?

The spec for the UX here is on page 12 of this doc: https://bug1150228.bugzilla.mozilla.org/attachment.cgi?id=8592387

> 2) In my freshly built copy of nightly, the link to "Privacy Notice" seems
> to be browser-default blue, rather than #4A90E2 (the blue color of other
> un-visited links in the intro). When visited, it is browser-default purple.
> It's also underlined. Shall I apply the same link styles to inline links
> throughout?

The links this bug is talking about is the footer links "More about new Tab" or "About your privacy".

The spec says the colour should be #171F26 for visited links which is what it is now...

Aaron, is this correct or should the colours of the footer links be different?

Comment 5

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: Screen Shot 2015-07-14 at 3.49.49 PM.png

> > 2) In my freshly built copy of nightly, the link to "Privacy Notice" seems
> > to be browser-default blue, rather than #4A90E2 (the blue color of other
> > un-visited links in the intro). When visited, it is browser-default purple.
> > It's also underlined. Shall I apply the same link styles to inline links
> > throughout?
> 
> The links this bug is talking about is the footer links "More about new Tab"
> or "About your privacy".

Got it. Shall I open another bug for the link styling issues in the paragraph text (see attached)? Or, since the footer may not be an issue, we could repurpose this bug.

Comment 6

[Aaron]

Marina, the Style Guide is incorrect...

The STATIC color of the footer links is #4890E2 (blue, not green), and the ROLLOVER color is #000000 (black).

My apologies, not sure how that happened.

Comment 7

[Marina Samuel [:emtwo]]

> Got it. Shall I open another bug for the link styling issues in the
> paragraph text (see attached)?

Yes please do open another bug for this separate issue and go based on Aaron's comment 6 for this bug.

Comment 8

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: bug1169241.patch

This is my first Firefox & hg patch submission ever. Please let me know if I have made obvious newbie mistakes.

Comment 9

[Marina Samuel [:emtwo]]

Comment on attachment 8635564 [details] [diff] [review]
bug1169241.patch

Review of attachment 8635564 [details] [diff] [review]:
-----------------------------------------------------------------

W00t Congrats on your first patch :)

Comment 10

[Justin Crawford [:hoosteeno] [:jcrawford]]

Thanks!

Comment 11

[Carsten Book [:Tomcat]]

Hi, this failed to apply, 

Fetching... done
Parsing... done
adding 1169241 to series file
renamed 1169241 -> bug1169241.patch
applying bug1169241.patch
patching file browser/base/content/newtab/newTab.css
Hunk #1 FAILED at 758
1 out of 1 hunks FAILED -- saving rejects to file browser/base/content/newtab/newTab.css.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh bug1169241.patch

could you take a look, maybe needs a rebase? Thanks!

Comment 12

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: Add hover style to footer links in newtab intro

Comment 13

[Justin Crawford [:hoosteeno] [:jcrawford]]

Comment on attachment 8636770 [details] [diff] [review]
Add hover style to footer links in newtab intro

The change required was different as a result of intervening changes, so I have a new patch for review.

Comment 14

[Justin Crawford [:hoosteeno] [:jcrawford]]

Thanks!

Comment 15

[Carsten Book [:Tomcat]]

that worked perfect Justin, thanks! and welcome to mozilla!

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7ecd5948ed30

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7ecd5948ed30

Comment 18

[Saheda Reza [:Antora]]

I found same issue depends on this bug on Firefox Nightly -- windows 8.1(32bit)

Build ID 	20150529030205
User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:41.0) Gecko/20100101 Firefox/41.0


It's okay on Latest Developer Edition & Latest Nightly

Developer Edition

Build ID 	20150805004014
User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:41.0) Gecko/20100101 Firefox/41.0

Latest Nightly

Build ID 	20150805030208
User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:42.0) Gecko/20100101 Firefox/42.0

[bugday-20150805]

Comment 19

[Saheda Reza [:Antora]]

It's also found on

Firefox nightly

Build ID 	20150528030206
User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:41.0) Gecko/20100101 Firefox/41.0

[bugday-20150805]

Comment 20

[Cornel Ionce [:noni] [Hubs QA]]

This is now indeed fixed now using latest builds.