1169315 - [System] TypeError: data.type is null" {file: "app://system.gaiamobile.org/js/signal_icon.js" line: 56

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Julien Wajsberg [:julienw]]

I'm traveling and from time to time I get this log in my console:

05-28 17:45:36.329  2161  2161 E GeckoConsole: [JavaScript Error: "TypeError: data.type is null" {file: "app://system.gaiamobile.org/js/signal_icon.js" line: 56}]

I don't like this because this happens in a if/else condition and if this throws we can't go to the "else" block...

The code seems to come from bug 1098168 which is in v2.2 too (the same line of code is in js/statusbar.js).

I don't know what is the user implication or what is the correct STR, but this looks easy to fix while this can bring bad behavior. So let's fix this.

Comment 1

[Gregor Wagner [:gwagner]]

Alive, can you take a look?

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Julien Wajsberg [:julienw] from comment #0)
> I'm traveling and from time to time I get this log in my console:
> 
> 05-28 17:45:36.329  2161  2161 E GeckoConsole: [JavaScript Error:
> "TypeError: data.type is null" {file:
> "app://system.gaiamobile.org/js/signal_icon.js" line: 56}]
> 
> I don't like this because this happens in a if/else condition and if this
> throws we can't go to the "else" block...
> 
> The code seems to come from bug 1098168 which is in v2.2 too (the same line
> of code is in js/statusbar.js).

This is confusing. Bug 1098168 is not in v2.2, exactly.

Comment 3

[Julien Wajsberg [:julienw]]

That's my mistake here then: bug 1098168 merely moved this line of code from statusbar.js to both signal_icon.js (note: and also roaming_icon.js). The line of code itself seems to come from bug 921389 which is really old.

So there are several possibilities here:
* either the move from bug 1098168 made this issue possible (in that case it's not in v2.2).
* or there is a gecko change that made it possible that data.type is null.

I don't know which possibility is the right one, I think you'll need to investigate a little more to know how the issue is possible, if it as always there, etc :)

Comment 4

[Gregor Wagner [:gwagner]]

No clean user impact.

Comment 5

[BMO Automation]

Firefox OS is not being worked on