Closed Bug 1169360 Opened 9 years ago Closed 6 years ago

Ship It should be carried forward if commit content hasn't changed

Categories

(MozReview Graveyard :: General, defect, P2)

Product:
MozReview Graveyard
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: gps, Unassigned)

References

Details

If there is a Ship It on an existing review request and someone rebases and pushes again and no file merges have occurred (the content of files is identical), Ship It should be carried forward to the new review request.

This will be useful for reducing bug/review spam when commits are unlanded.
Priority: -- → P2
Why do the file contents have to be the same? If I get "r+ with comments addressed" and I address those comments and re-push the series of patches it should keep the r+. I'm thinking particularly of the workflow in bug 1175166.
See Also: → 1175166
Product: Developer Services → MozReview
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.