Closed Bug 1169632 Opened 9 years ago Closed 9 years ago

Conversation name vanishes if the window is detached by dragging

Categories

(Hello (Loop) :: Client, defect, P4)

defect
Points:
2

Tracking

(firefox43 verified)

VERIFIED FIXED
mozilla43
Iteration:
43.3 - Sep 21
Tracking Status
firefox43 --- verified

People

(Reporter: adalucinet, Assigned: standard8)

Details

(Whiteboard: [conversatio] [bug])

Attachments

(1 file)

Reproducible on 39.0b1 build 2 (Build ID: 20150523155636)
Affected platforms: Windows 7 64-bit, Mac OS X 10.9.5, Ubuntu 14.04 64-bit

Steps to reproduce:
1. Start a call.
2. Detach conversation by dragging the window.

Expected result:
Conversation name is displayed.

Actual result:
Conversation name is not displayed.

Notes:
1. Screencast: https://goo.gl/7KZQMx
2. Browser console output when detaching: 'TypeError: win.gBrowser is null' thrown by ReaderParent.jsm:168:0
Rank: 41
Flags: firefox-backlog+
Priority: -- → P4
Whiteboard: [conversatio] [bug]
I took a quick look at this and it turns out that the drag specific detach code is trying to set the title, but hasn't got the right title. Additionally, the detachChatbox code already has embedded within the facility for setting the title on detach.

So I think all we need to do is to remove the broken part of the code.
Attachment #8659800 - Flags: review?(mixedpuppy)
Assignee: nobody → standard8
Attachment #8659800 - Flags: review?(mixedpuppy) → review+
Iteration: --- → 43.3 - Sep 21
Points: --- → 2
https://hg.mozilla.org/mozilla-central/rev/0c7ecbc66443
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Flags: qe-verify+
Verified fixed with latest 43.0a1 (from 2015-09-15), across platforms [1].

[1] Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 12.04 32-bit.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: