Closed
Bug 1169686
Opened 9 years ago
Closed 9 years ago
Package error: Missing file(s): bin/components/dom_devicestorage.xpt, bin/components/pipboot.xpt
Categories
(Thunderbird :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 41.0
People
(Reporter: ssitter, Assigned: ssitter)
References
Details
Attachments
(1 file)
1.60 KB,
patch
|
rkent
:
review+
|
Details | Diff | Splinter Review |
https://treeherder.mozilla.org/logviewer.html#?job_id=19210&repo=comm-central Error: /builds/slave/tb-c-cen-lx-000000000000000000/build/objdir-tb/mail/installer/package-manifest:299: Missing file(s): bin/components/dom_devicestorage.xpt Error: /builds/slave/tb-c-cen-lx-000000000000000000/build/objdir-tb/mail/installer/package-manifest:632: Missing file(s): bin/components/pipboot.xpt make[3]: *** [stage-package] Error 1
Assignee | ||
Comment 1•9 years ago
|
||
pipboot.xpt was removed with https://hg.mozilla.org/mozilla-central/rev/0c1cdda7c323 dom_devicestorage.xpt was removed with https://hg.mozilla.org/mozilla-central/rev/4820fb6d8eb7
Comment 2•9 years ago
|
||
Can you do the patch to fix this?
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Comment 4•9 years ago
|
||
Comment on attachment 8612955 [details] [diff] [review] Remove dom_devicestorage.xpt and pipboot.xpt from package-manifest LGTM
Attachment #8612955 -
Flags: review?(rkent) → review+
Assignee | ||
Updated•9 years ago
|
Comment 5•9 years ago
|
||
What about removed-files.in, do files need to be added there?
Assignee | ||
Comment 6•9 years ago
|
||
I think its not necessary. Those files are not on disk because Firefox/Thunderbird ships xpt files linked together as components/interfaces.xpt in omni.ja file.
Comment 7•9 years ago
|
||
Ah yes, thanks for the clarification!
Comment 8•9 years ago
|
||
I'll land this shortly.
Comment 9•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/42fcfd06884c -> FIXED (/im and /suite also need fixing though)
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 41.0
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•