1169712 - js fails to build on Fedora 22 / gcc 5.1

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom Tromey :tromey]

I upgraded to Fedora 22, which uses GCC 5.1.1 as its system compiler.
GCC now says:

In file included from /home/tromey/firefox-git/tree-2/obj-x86_64-unknown-linux-gnu/js/src/jsapi-tests/Unified_cpp_js_src_jsapi-tests2.cpp:2:0:
/home/tromey/firefox-git/tree-2/js/src/jsapi-tests/testGCMarking.cpp: In member function ‘void CCWTestTracer::callback(void**, JS::TraceKind)’:
/home/tromey/firefox-git/tree-2/js/src/jsapi-tests/testGCMarking.cpp:21:43: error: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘JS::TraceKind’ [-Werror=format=]
         printf("kind         = %d\n", kind);
                                           ^
/home/tromey/firefox-git/tree-2/js/src/jsapi-tests/testGCMarking.cpp:22:51: error: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘JS::TraceKind’ [-Werror=format=]
         printf("expectedKind = %d\n", expectedKind);
                                                   ^


It looks like -Wformat has gotten a bit more pedantic.

Patch to follow.

Comment 1

[Tom Tromey :tromey]

Attachment: add casts for GCC 5.1 -Wformat

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8612998 [details] [diff] [review]
add casts for GCC 5.1 -Wformat

Review of attachment 8612998 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6b30c18e49e

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a281ea0a58e6

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a281ea0a58e6