Closed
Bug 1169758
Opened 9 years ago
Closed 9 years ago
Reloading repo doesn't work after filtering repo by author + get|next N
Categories
(Tree Management :: Treeherder, defect, P2)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jfrench, Assigned: camd)
References
()
Details
Attachments
(1 file)
With the recent get next N changes (fromchange, tochange) in bug 1078209 pushed to stage, I can reproduce one scenario where the Repo doesn't reload when it should. To reproduce: o load m-i and filter by author, eg. https://treeherder.allizom.org/#/jobs?repo=mozilla-inbound&author=smichaud@pobox.com o scroll to the bottom and click on get|next 10 *twice o nb. ...there aren't any more resultsets with that author name anyway o click on the mozilla-inbound repo button at the top navbar to reload m-i Expected: All m-i pushes reload, with no filter. Observed: Nothing happens.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → cdawson
Assignee | ||
Comment 1•9 years ago
|
||
I think that has something to do with the "skipNextReload" param. It's not getting set back to false if there are no more items to load.
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8614327 -
Flags: review?(emorley)
Comment 3•9 years ago
|
||
Comment on attachment 8614327 [details] [review] PR r+, with the indentation fix :-)
Attachment #8614327 -
Flags: review?(emorley) → review+
Comment 4•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/25baf8d2b3668d461a1efa1b871611b84ee89057 Bug 1169758 - reload repo after author filter + get next N
Assignee | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•