1169887 - Consecutive similar markers should be aggregated somehow

Status: RESOLVED WONTFIX

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Description

[Sami Jaktholm]

Attachment: testcase.html

STR:
1. Open the attached HTML file.
2. Open profiler and start profiling.
3. Let the recording run for 10-15 seconds.
4. Stop the recording.
5. Look for folded 'Function call' markers and click on a long one.

What happens: The sidebar shows that the function call took [length of the folded marker] seconds while really there was multiple calls a second apart and each took ~0.01ms.

See attached the attached screenshot (especially the upper one is quite confusing).

Comment 1

[Sami Jaktholm]

Attachment: screenshots.png

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

These were backed out in bug 1169439 -- need to come up with a good UX story for these.

Comment 4

[Victor Porof [:vporof][:vp]]

Keeping everything on a single row sounds like a good idea to me. Basically, maintaing the previous implementation, but don't show the "parent" marker as a single contiguous rectangle.

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Check out how Chrome does rasterizing markers -- a bit different as these are on a diff thread, but they have a metamarker "Rasterize x7", and these markers don't have any actionable data. As more meta is added to style/reflow markers, I'd imagine I'd want them uncollapsed by default, but we'll see

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

On IRC, wilsonpage pinged me of confusion with collapsing of JS markers, since we use different names for generic and specific:

Function Call>
-  Script Tag
-  Script Tag

I think we should reserve any kind of similar marker collapsing to only a few types (recalc, layout, paint)

Comment 7

[Victor Porof [:vporof][:vp]]

Triaging. Filter on ADRENOCORTICOTROPIC (yes).

Comment 8

[Julien Wajsberg [:julienw]]

Now that we replaced the old performance panel by the Firefox Profiler (see Bug 1668219) we're closing bugs related to this.

Filter on MASSCLOSEOLDPERFTOOLBUGS.