Closed
Bug 1169898
Opened 9 years ago
Closed 9 years ago
The 'Trigger a try build' button should be disabled unless the review has been published
Categories
(MozReview Graveyard :: General, defect, P1)
MozReview Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: francois, Assigned: dminor)
References
Details
Attachments
(1 file)
The UI makes it possible to request a Try run on a draft review (before it's published) but it fails with a generic error message. Ideally, that option should be hidden until the review has been published.
|
Assignee | |
Comment 1•9 years ago
|
||
Like François says, Try runs on draft reviews don't work properly. In Bug 1170380, previously published commits were sent to Try rather than the draft commits. We should disable the 'Try' button unless the review has been published.
Priority: -- → P1
Summary: Requesting a try run on a draft review doesn't work → The 'Trigger a try build' button should be disabled unless the review has been published
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → dminor
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•9 years ago
|
||
mozreview: disable 'Try' button unless review has been published (bug 1169898); r?mdoglio Attempting a 'Try' run on a draft review will fail or cause a Try run to be started using previously published commits. We should disable the button unless the draft has been published.
Attachment #8613852 -
Flags: review?(mdoglio)
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8613852 [details] MozReview Request: mozreview: disable 'Try' button unless review has been published (bug 1169898); r?mdoglio https://reviewboard.mozilla.org/r/9815/#review8643 Ship It!
Attachment #8613852 -
Flags: review?(mdoglio) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Thanks, pushed to: https://hg.mozilla.org/hgcustom/version-control-tools/rev/04688f7ff035
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Developer Services → MozReview
You need to log in
before you can comment on or make changes to this bug.
Description
•